-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh GAPIcs #715
Refresh GAPIcs #715
Conversation
(Mostly DLP)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -34,24 +34,34 @@ | |||
use Google\GAX\AgentHeaderDescriptor; | |||
use Google\GAX\ApiCallable; | |||
use Google\GAX\CallSettings; | |||
use Google\GAX\GrpcConstants; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -72,19 +82,10 @@ | |||
* ``` | |||
* try { | |||
* $dlpServiceClient = new DlpServiceClient(); | |||
* $name = "EMAIL_ADDRESS"; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
'createInspectOperation' => [ | ||
'operationReturnType' => '\Google\Privacy\Dlp\V2beta1\InspectOperationResult', | ||
'metadataReturnType' => '\Google\Privacy\Dlp\V2beta1\InspectOperationMetadata', | ||
], | ||
]; | ||
} | ||
|
||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* @param DeidentifyConfig $deidentifyConfig Configuration for the de-identification of the list of content items. | ||
* @param InspectConfig $inspectConfig Configuration for the inspector. | ||
* @param ContentItem[] $items The list of items to inspect. Up to 100 are allowed per request. | ||
* All items will be treated as text/*. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* $operationResponse = $dlpServiceClient->analyzeDataSourceRisk($privacyMetric, $sourceTable); | ||
* $operationResponse->pollUntilComplete(); | ||
* if ($operationResponse->operationSucceeded()) { | ||
* $result = $operationResponse->getResult(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, nice work!
(Mostly DLP)
The build will keep failing until
google/proto-client ^0.25
andgoogle/gax ^0.25
are released.Related PRs:
googleapis/gax-php#115
googleapis/proto-client-php#41