Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh GAPIcs #715

Merged
merged 3 commits into from
Oct 31, 2017
Merged

Refresh GAPIcs #715

merged 3 commits into from
Oct 31, 2017

Conversation

vam-google
Copy link
Contributor

@vam-google vam-google commented Oct 26, 2017

(Mostly DLP)
The build will keep failing until google/proto-client ^0.25 and google/gax ^0.25 are released.
Related PRs:
googleapis/gax-php#115
googleapis/proto-client-php#41

(Mostly DLP)
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2017
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -34,24 +34,34 @@
use Google\GAX\AgentHeaderDescriptor;
use Google\GAX\ApiCallable;
use Google\GAX\CallSettings;
use Google\GAX\GrpcConstants;

This comment was marked as spam.

@@ -72,19 +82,10 @@
* ```
* try {
* $dlpServiceClient = new DlpServiceClient();
* $name = "EMAIL_ADDRESS";

This comment was marked as spam.

'createInspectOperation' => [
'operationReturnType' => '\Google\Privacy\Dlp\V2beta1\InspectOperationResult',
'metadataReturnType' => '\Google\Privacy\Dlp\V2beta1\InspectOperationMetadata',
],
];
}


This comment was marked as spam.

* @param DeidentifyConfig $deidentifyConfig Configuration for the de-identification of the list of content items.
* @param InspectConfig $inspectConfig Configuration for the inspector.
* @param ContentItem[] $items The list of items to inspect. Up to 100 are allowed per request.
* All items will be treated as text/*.

This comment was marked as spam.

This comment was marked as spam.

* $operationResponse = $dlpServiceClient->analyzeDataSourceRisk($privacyMetric, $sourceTable);
* $operationResponse->pollUntilComplete();
* if ($operationResponse->operationSucceeded()) {
* $result = $operationResponse->getResult();

This comment was marked as spam.

Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, nice work!

@vam-google vam-google changed the title [WIP]Refresh GAPIcs Refresh GAPIcs Oct 31, 2017
@vam-google vam-google merged commit 0cfa907 into googleapis:master Oct 31, 2017
This was referenced Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants